Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195460
--- Diff: libminifi/src/core/ProcessSessionReadCallback.cpp ---
@@ -64,16 +64,16 @@ int64_t
ProcessSessionReadCallback::process(std::shared_ptr<io::BaseStream> stre
bool ProcessSessionReadCallback::commit() {
bool success = false;
- logger_->log_info("committing export operation to %s",
_destFile.c_str());
--- End diff --
ditto on the c_str(). It adds overhead and is vestigial.
---
