[ 
https://issues.apache.org/jira/browse/NIFI-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331385#comment-16331385
 ] 

ASF GitHub Bot commented on NIFI-4795:
--------------------------------------

GitHub user sbouchex opened a pull request:

    https://github.com/apache/nifi/pull/2414

    NIFI-4795 AllowableValues for AccessPolicySummaryDTO are incorrect

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    
    - [ x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ x] Have you written or updated unit tests to verify your changes?
    - [ x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ x] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [x ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [x ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/infovista/nifi NIFI-4795

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2414
    
----
commit a53e034406317b3179afadc663541ab9d05ca3d9
Author: sbouchex <sbouchex@...>
Date:   2018-01-18T22:49:55Z

    Fixed allowed values

----


> AllowableValues for AccessPolicySummaryDTO are incorrect
> --------------------------------------------------------
>
>                 Key: NIFI-4795
>                 URL: https://issues.apache.org/jira/browse/NIFI-4795
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.6.0
>            Reporter: Sébastien Bouchex Bellomié
>            Priority: Minor
>
> org.apache.nifi.authorization.ActionEnum defines lowercase values "read" and 
> "write", however, org.apache.nifi.web.api.dto.AccessPolicySummaryDTO (action) 
> defines allowed values as "READ" and "WRITE" (uppercase)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to