[
https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333354#comment-16333354
]
ASF GitHub Bot commented on NIFI-4786:
--------------------------------------
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2409
@SunSatION , thanks for submitting this PR, it looks like good stuff.
May I ask how you tested the changes? For PutKinesisFirehose, I was able
to run the integration test suite successfully, and I was able to manually
build and run a simple flow sending data to Kinesis Firehose. For
PutKinesisStream, the manual flow building worked, but I get exceptions running
the integration test suite (ITPutKinesisStream.testIntegrationSuccess) as it
calls `putRecords()`:
```
com.amazonaws.SdkClientException: Unable to marshall request to JSON:
com.fasterxml.jackson.dataformat.cbor.CBORGenerator.getOutputContext()Lcom/fasterxml/jackson/core/json/JsonWriteContext;
```
Did you try the integration tests, and did they work for you? I don't
believe your change introduced this issue. A quick check of the master branch
suggests it was already there, but it complicated testing.
> Allow Expression Evaluation to Kinesis/Firehose Stream Name
> -----------------------------------------------------------
>
> Key: NIFI-4786
> URL: https://issues.apache.org/jira/browse/NIFI-4786
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.5.0
> Reporter: Dorian Bugeja
> Priority: Minor
> Labels: features, performance, pull-request-available
> Attachments:
> NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name_NIFI_4786___Allow_1.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Currenctly, the Stream name propoerty for both Firehose and Kinesis does not
> support the expression language. Routing can be performed based on an
> attribute of the flowfile and having a single component rather than multiple
> for each one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
