[
https://issues.apache.org/jira/browse/NIFI-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335950#comment-16335950
]
ASF GitHub Bot commented on NIFI-4801:
--------------------------------------
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi/pull/2428
NIFI-4801 Fixes Swagger spec for uploadTemplate
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi NIFI-4801
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2428.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2428
----
commit 19f78a6ee63a7e833893c009978b3f9b22b2b35e
Author: Kevin Doran <kdoran@...>
Date: 2018-01-23T14:59:58Z
NIFI-4801 Fixes Swagger spec for uploadTemplate
----
> Rest-api swagger definition produces non-functional template import in Python
> -----------------------------------------------------------------------------
>
> Key: NIFI-4801
> URL: https://issues.apache.org/jira/browse/NIFI-4801
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.5.0
> Environment: Python 2.7/3.6
> Reporter: Daniel Chaffelson
> Assignee: Kevin Doran
> Priority: Major
> Fix For: 1.6.0
>
> Attachments: corrected-swagger.json
>
>
> The swagger.json produced when compiling NiFi-1.5.0 results in a
> ProcessgroupsApi().upload_template function that only accepts the id of the
> Process Group to receive the template, and no option to specify the template
> itself.
> It would appear that the underlying API call expects the template to be the
> body of the request, but the produced function does not allow it to be
> specified. This is changed from NiFi-1.2.0 where a 'template' keyword
> argument was included.
> It may also be related to how the TemplatesApi().export_template function
> used to produce a TemplateDTO and now produces a string.
> I am unsure in which version since 1.2.0 this changed, it may not
> specifically be just 1.5.0 code.
> An example of the procedurally generated code can be found at:
> [https://github.com/Chaffelson/nifi-python-swagger-client/blob/master/swagger_client/apis/processgroups_api.py]
> And documentation at:
> [http://nifi-python-swagger-client.readthedocs.io/en/latest/ProcessgroupsApi/#upload_template]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
