[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

[mgaido91]

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2426#discussion_r163554821
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ---
    @@ -213,11 +219,22 @@
     
         public static final PropertyDescriptor PROP_SSL_CONTEXT_SERVICE = new 
PropertyDescriptor.Builder()
                 .name("SSL Context Service")
    -            .description("The SSL Context Service used to provide client 
certificate information for TLS/SSL (https) connections.")
    +            .description("The SSL Context Service used to provide client 
certificate information for TLS/SSL (https) connections."
    +                    + " It is also used to connect to HTTPS Proxy.")
                 .required(false)
                 .identifiesControllerService(SSLContextService.class)
                 .build();
     
    +    public static final PropertyDescriptor PROP_PROXY_TYPE = new 
PropertyDescriptor.Builder()
    +            .name("Proxy Type")
    +            .displayName("Proxy Type")
    +            .description("The type of the proxy we are connecting to.")
    +            .required(true)
    +            .allowableValues(HTTP, HTTPS)
    +            .defaultValue(HTTP.getValue())
    +            .expressionLanguageSupported(true)
    --- End diff --
    
    thanks, I'll make it like this


---