Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r163883982
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
---
@@ -95,15 +102,54 @@
public static final PropertyDescriptor WRITE_CONCERN = new
PropertyDescriptor.Builder()
.name("Write Concern")
+ .displayName("Write Concern")
.description("The write concern to use")
.required(true)
.allowableValues(WRITE_CONCERN_ACKNOWLEDGED,
WRITE_CONCERN_UNACKNOWLEDGED, WRITE_CONCERN_FSYNCED, WRITE_CONCERN_JOURNALED,
WRITE_CONCERN_REPLICA_ACKNOWLEDGED,
WRITE_CONCERN_MAJORITY)
.defaultValue(WRITE_CONCERN_ACKNOWLEDGED)
.build();
+ static final PropertyDescriptor RESULTS_PER_FLOWFILE = new
PropertyDescriptor.Builder()
+ .name("results-per-flowfile")
+ .displayName("Results Per FlowFile")
+ .description("How many results to put into a flowfile at once.
The whole body will be treated as a JSON array of results.")
+ .required(false)
+ .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+ .defaultValue("1")
+ .build();
+
+ static final PropertyDescriptor BATCH_SIZE = new
PropertyDescriptor.Builder()
+ .name("Batch Size")
+ .displayName("Batch Size")
+ .description("The number of elements returned from the server
in one batch")
+ .required(false)
+ .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+ .defaultValue("1")
+ .build();
+
+ static final PropertyDescriptor QUERY_ATTRIBUTE = new
PropertyDescriptor.Builder()
+ .name("mongo-agg-query-attribute")
+ .displayName("Query Output Attribute")
+ .description("If set, the query will be written to a specified
attribute on the output flowfiles.")
+ .expressionLanguageSupported(true)
+ .addValidator(Validator.VALID)
--- End diff --
Since this has to be a valid attribute name, I recommend changing this to
`StandardValidators.ATTRIBUTE_KEY_PROPERTY_NAME_VALIDATOR`
Also, since you may be writing this attribute in GetMongo and
RunMongoAggregation, there should be a WritesAttribute annotation on both
processors (same goes for mime.type or any other attribute that is written)
---
