[
https://issues.apache.org/jira/browse/NIFI-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343720#comment-16343720
]
ASF GitHub Bot commented on NIFI-4789:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2411#discussion_r164510291
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
---
@@ -70,33 +65,51 @@
@Tags({"grok", "log", "text", "parse", "delimit", "extract"})
@CapabilityDescription("Evaluates one or more Grok Expressions against the
content of a FlowFile, " +
"adding the results as attributes or replacing the content of the
FlowFile with a JSON " +
- "notation of the matched content")
+ "notation of the matched content\n" +
+ "uses https://github.com/thekrakken/java-grok.";)
@WritesAttributes({
- @WritesAttribute(attribute = "grok.XXX", description = "When operating
in flowfile-attribute mode, each of the Grok identifier that is matched in the
flowfile " +
- "will be added as an attribute, prefixed with \"grok.\" For
example," +
- "if the grok identifier \"timestamp\" is matched, then the value
will be added to an attribute named \"grok.timestamp\"")})
+ @WritesAttribute(attribute = "{result prefix}XXX", description = "When
operating in flowfile-attribute mode, each of the Grok identifier that is
matched in the flowfile " +
+ "will be added as an attribute, prefixed with \"{result prefix}\"
For example," +
+ "if the grok identifier \"timestamp\" is matched, then the value
will be added to an attribute named \"{result prefix}timestamp\""),
+
+ @WritesAttribute(attribute = "ExtractGrok.exception", description
= "if an error occurs, an exception will be written to this attribute, " +
+ "and the flow routed to 'unmatched' ")
--- End diff --
This should read "and the FlowFile routed" rather than "and the flow
routed". In such a case, though, we should not be routing to 'unmatched' but
rather we should route to a failure relationship.
> Enhance ExtractGrok processor to handle multiple grok expressions
> -----------------------------------------------------------------
>
> Key: NIFI-4789
> URL: https://issues.apache.org/jira/browse/NIFI-4789
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
> Affects Versions: 1.2.0, 1.5.0
> Environment: all
> Reporter: Charles Porter
> Priority: Minor
> Labels: features
>
> Many flows require running several grok expressions against an input to
> correctly tag and extract data. using many separate grok processors to
> accomplish this is unwieldy and hard to maintain. Supporting multiple grok
> expressions delimited by comma or user selected delimiter greatly simplifies
> this.
> Feature is coded and tested, ready for pull request, if feature is approved
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
