[ 
https://issues.apache.org/jira/browse/NIFI-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344215#comment-16344215
 ] 

ASF GitHub Bot commented on NIFI-4827:
--------------------------------------

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2443#discussion_r164602936
  
    --- Diff: 
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
 ---
    @@ -89,6 +99,17 @@ public ValidationResult validate(final String subject, 
final String value, final
             .expressionLanguageSupported(true)
             .addValidator(DOCUMENT_VALIDATOR)
             .build();
    +
    +    static final AllowableValue LOC_BODY = new AllowableValue("body", 
"Body");
    +    static final AllowableValue LOC_PARAM = new AllowableValue("param", 
"Query Parameter");
    +    static final PropertyDescriptor QUERY_LOC = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    Everything is tied to that parameter (or should be tied to it). One of the 
things I'm learning from having to train someone on NiFi is that "explicit is 
better" for a lot of people. I think the meaning of a blank query wouldn't be 
obvious to a lot of users, and you cannot trust that they'll read the 
description closely rather than cursing out the product because it seems to be 
"mysteriously misbehaving."


> Make GetMongo able to use flowfiles for queries
> -----------------------------------------------
>
>                 Key: NIFI-4827
>                 URL: https://issues.apache.org/jira/browse/NIFI-4827
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Minor
>
> GetMongo should be able to retrieve a valid query from the flowfile content 
> or allow the incoming flowfile to provide attributes to power EL statements 
> in the Query configuration field. Allowing the body to be used would allow 
> GetMongo to be used in a much more generic way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to