Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1997#discussion_r165030818
  
    --- Diff: 
nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java
 ---
    @@ -0,0 +1,180 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package com.apache.nifi.processors.simulator;
    +
    +import be.cetic.tsimulus.config.Configuration;
    +import org.apache.nifi.annotation.behavior.InputRequirement;
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.annotation.lifecycle.OnScheduled;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.logging.ComponentLog;
    +import org.apache.nifi.processor.AbstractProcessor;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.ProcessorInitializationContext;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.exception.ProcessException;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.joda.time.LocalDateTime;
    +import scala.Some;
    +import scala.Tuple3;
    +import scala.collection.JavaConverters;
    +
    +import java.util.List;
    +import java.util.Set;
    +import java.util.Collections;
    +import java.util.HashSet;
    +import java.util.ArrayList;
    +
    +@Tags({"Simulator, Timeseries, IOT, Testing"})
    +@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
    +@CapabilityDescription("Generates realistic time series data using the 
TSimulus time series generator, and places the values into the flowfile in a 
CSV format.")
    +public class GenerateTimeSeriesFlowFile extends AbstractProcessor {
    +
    +    private Configuration simConfig = null;
    +    private boolean isTest = false;
    +
    +    public static final PropertyDescriptor SIMULATOR_CONFIG = new 
PropertyDescriptor
    +            .Builder().name("SIMULATOR_CONFIG")
    +            .displayName("Simulator Configuration File")
    +            .description("The JSON configuration file to use to configure 
TSimulus")
    +            .required(true)
    +            .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor PRINT_HEADER = new 
PropertyDescriptor
    +            .Builder().name("PRINT_HEADER")
    +            .displayName("Print Header")
    +            .description("Directs the processor whether to print a header 
line or not.")
    +            .required(true)
    +            .allowableValues("true", "false")
    +            .defaultValue("false")
    +            .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
    +            .build();
    +
    +    public static final Relationship SUCCESS = new Relationship.Builder()
    +            .name("Success")
    +            .description("When the flowfile is successfully generated")
    --- End diff --
    
    Needs a little cleanup. Consider something like this:
    
    > "When the flowfile is successfully generated, it is transferred to this 
relationship."


---

Reply via email to