[
https://issues.apache.org/jira/browse/MINIFICPP-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350693#comment-16350693
]
ASF GitHub Bot commented on MINIFICPP-383:
------------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/257
MINIFICPP-383: Implement env variable replacement and set the default…
… for repos to prefix with MINIFI_HOME
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-383
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #257
----
commit 00509f67df0b0cf8a34a30c8b70fbe8effab5c10
Author: Marc Parisi <phrocker@...>
Date: 2018-02-02T17:24:32Z
MINIFICPP-383: Implement env variable replacement and set the default for
repos to prefix with MINIFI_HOME
----
> No matter the start directory for minifi.sh, repositories are created in the
> current working directory
> ------------------------------------------------------------------------------------------------------
>
> Key: MINIFICPP-383
> URL: https://issues.apache.org/jira/browse/MINIFICPP-383
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Affects Versions: 0.1.0, 0.2.0, 0.3.0
> Reporter: marco polo
> Priority: Major
> Fix For: 0.5.0
>
>
> No matter where the user starts MiNiFi from the directory in which the repos
> are created is the current working directory. This should be changed to use a
> persistent directory based on the root of the installation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
