ASF GitHub Bot commented on MINIFICPP-385:

GitHub user phrocker opened a pull request:


    MINIFICPP-385: Add countdown latch and notify stop so that we gracefu…

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    - [ ] Is your initial contribution a single, squashed commit?
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-385

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #258
commit 63150d19f31ceacdff01868aa02ca3bea96d9345
Author: Marc Parisi <phrocker@...>
Date:   2018-01-26T13:23:46Z

    MINIFICPP-385: Add countdown latch and notify stop so that we gracefully 
close sockets.


> RPG destruction can lead to EOFException in NiFi when sockets are not closed. 
> ------------------------------------------------------------------------------
>                 Key: MINIFICPP-385
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-385
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Major
> Current solution has not caused the issue in hours:
> Setup a countdown latch using RAII to control closure while there are any 
> open sockets in the ontrigger function in RPG. 

This message was sent by Atlassian JIRA

Reply via email to