ASF GitHub Bot commented on NIFI-4853:

Github user MikeThomsen commented on a diff in the pull request:

    --- Diff: 
    @@ -0,0 +1,186 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.mongodb;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.serialization.SimpleRecordSchema;
    +import org.apache.nifi.serialization.record.MapRecord;
    +import org.apache.nifi.serialization.record.MockRecordParser;
    +import org.apache.nifi.serialization.record.RecordField;
    +import org.apache.nifi.serialization.record.RecordFieldType;
    +import org.apache.nifi.serialization.record.RecordSchema;
    +import org.apache.nifi.util.MockFlowFile;
    +import org.apache.nifi.util.MockProcessContext;
    +import org.apache.nifi.util.TestRunner;
    +import org.apache.nifi.util.TestRunners;
    +import org.bson.Document;
    +import org.junit.After;
    +import org.junit.Assert;
    +import org.junit.Before;
    +import org.junit.Test;
    +import java.nio.charset.StandardCharsets;
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.Iterator;
    +import java.util.List;
    +import static org.junit.Assert.assertEquals;
    +public class PutMongoRecordTest extends MongoWriteTestBase {
    --- End diff --
    Make sure to put an @Ignore here before merging since these are integration 

> PutMongoRecord doesn't handle nested records
> --------------------------------------------
>                 Key: NIFI-4853
>                 URL: https://issues.apache.org/jira/browse/NIFI-4853
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
> PutMongoRecord works well with flat records, but when attempting to put in 
> nested records (records whose fields are arrays or records themselves), the 
> Mongo serializer doesn't know how to handle the complex NiFi record field 
> types (such as MapRecord).
> The fix is to traverse all fields in the record, transforming the fields (if 
> necessary) to Java objects for use by the Mongo serializer(s). Something very 
> similar was done for PutDruidRecord, and in fact there is a utility method 
> DataTypeUtils.convertRecordFieldtoObject() that can perform this task.

This message was sent by Atlassian JIRA

Reply via email to