[
https://issues.apache.org/jira/browse/NIFI-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357420#comment-16357420
]
ASF GitHub Bot commented on NIFI-4830:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2459
NIFI-4830: Fixed logic errors in BLOB/CLOB processing in JdbcCommon
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4830
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2459.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2459
----
commit 91084f882d9fd5ec7256c3f279f959c9f7dd2a30
Author: Matthew Burgess <mattyb149@...>
Date: 2018-02-08T19:02:58Z
NIFI-4830: Fixed logic errors in BLOB/CLOB processing in JdbcCommon
----
> Blob not being read properly from Database to Avro
> --------------------------------------------------
>
> Key: NIFI-4830
> URL: https://issues.apache.org/jira/browse/NIFI-4830
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Israel Varea
> Assignee: Matt Burgess
> Priority: Major
>
> When using QueryDatabaseTable or any other component using JdbcCommon.java,
> the Blob column of the database is not fetched correctly to the Avro
> ByteBuffer. Instead of fetching whole file, only first bytes which are
> different to zero are added. Then, the rest of the bytes remain with zero
> value.
> Specifically, this code in JdbcCommon.java should be fixed:
> {code:java}
> if (javaSqlType == BLOB) {
> Blob blob = rs.getBlob(i);
> if (blob != null) {
> long numChars = blob.length();
> byte[] buffer = new byte[(int) numChars];
> InputStream is = blob.getBinaryStream();
> int index = 0;
> int c = is.read();
> while (c > 0) {
> buffer[index++] = (byte) c;
> c = is.read();
> }
> ByteBuffer bb = ByteBuffer.wrap(buffer);
> rec.put(i - 1, bb);
> blob.free();
> } else {
> rec.put(i - 1, null);
> }
> continue;
> }
> {code}
> Notice the while statement.
> The whole block should be replaced for something like
> {code:java}
> if (javaSqlType == BLOB) {
> Blob blob = rs.getBlob(i);
> if (blob != null) {
> long blobLength = blob.length();
>
> byte[] blobAsBytes = blob.getBytes(1,
> (int)blobLength);
> ByteBuffer bb = ByteBuffer.wrap(blobAsBytes);
> rec.put(i - 1, bb);
> blob.free();
> } else {
> rec.put(i - 1, null);
> }
> continue;
> }
> {code}
> This has been tested locally and it works! :)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
