GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2460
NIFI-4858: Expose Request Timeout from HTTP Context Map and use that â¦
â¦to set as the timeout of the 'AsyncContext' in HandleHttpRequest.
Otherwise, the request will never timeout (which is OK because the
HttpContextMap will handle this). However, Jetty behind the scenes is adding a
task to Scheduled Executor for each request with a delay of whatever the
timeout is set to. Since it's currently set to Long.MAX_VALUE, that task will
never be run and as a result the ExecutorService's queue will grow
indefinitely, eventually exhausting the JVM Heap
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4858
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2460.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2460
----
commit d14f62f84b96fa8a7adddcfa9299469d41b0877e
Author: Mark Payne <markap14@...>
Date: 2018-02-08T20:02:06Z
NIFI-4858: Expose Request Timeout from HTTP Context Map and use that to set
as the timeout of the 'AsyncContext' in HandleHttpRequest. Otherwise, the
request will never timeout (which is OK because the HttpContextMap will handle
this). However, Jetty behind the scenes is adding a task to Scheduled Executor
for each request with a delay of whatever the timeout is set to. Since it's
currently set to Long.MAX_VALUE, that task will never be run and as a result
the ExecutorService's queue will grow indefinitely, eventually exhausting the
JVM Heap
----
---
