[ 
https://issues.apache.org/jira/browse/NIFI-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361242#comment-16361242
 ] 

ASF GitHub Bot commented on NIFI-4840:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2449#discussion_r167647277
  
    --- Diff: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ---
    @@ -1644,9 +1644,9 @@ Divide. This is to preserve backwards compatibility 
and to not force rounding er
     
     *Description*: [.description]#Converts the Subject from a Base 10 number 
to a different Radix (or number base). An optional
        second argument can be used to indicate the minimum number of 
characters to be used. If the converted value
    -   has fewer than this number of characters, the number will be padded 
with leading zeroes.
    +   has fewer than this number of characters, the number will be padded 
with leading zeroes.#
    --- End diff --
    
    I think that, instead of moving the # character, it'd be better to just 
remove the carriage return between this line and the next one, no? (same 
applies for fromRadix). Otherwise, the display is a bit weird in the doc:
    
https://github.com/Leah-Anderson/nifi/blob/a445ee4d141ea1218d3cf5c47abb5171c5890f43/nifi-docs/src/main/asciidoc/expression-language-guide.adoc#fromradix


> Fix Formatting For Expression Language Guide (toRadix/fromRadix)
> ----------------------------------------------------------------
>
>                 Key: NIFI-4840
>                 URL: https://issues.apache.org/jira/browse/NIFI-4840
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Documentation & Website
>    Affects Versions: 1.5.0
>            Reporter: Leah Anderson
>            Priority: Trivial
>              Labels: documentation
>             Fix For: 1.6.0
>
>         Attachments: Screenshot from 2018-02-04 19-26-40.png
>
>
> The documentation in the expression language guide is not formatted correctly 
> for the toRadix/fromRadix sections due to a misplaced # sign. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to