[ 
https://issues.apache.org/jira/browse/NIFI-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361620#comment-16361620
 ] 

ASF GitHub Bot commented on NIFI-4866:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2464#discussion_r167726214
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientService.java
 ---
    @@ -212,6 +213,7 @@ public void onEnabled(final ConfigurationContext 
context) throws InitializationE
                 final Admin admin = this.connection.getAdmin();
                 if (admin != null) {
                     admin.listTableNames();
    +                masterAddress = 
admin.getClusterStatus().getMaster().getHostAndPort();
    --- End diff --
    
    @acumartini Thanks for sharing that. I agree with the idea, that ClusterId 
is more consistent. However, I still prefer using master address as the 
hostname part of transit URI, because ClusterId is an UUID string, which has 
less context in itself than master address. But I think having ClusterId in 
NiFi provenance events would be useful in some situations. I added a note on 
NIFI-4867 for future improvement. Thanks again!


> HBase_1_1_2_ClientService performance dropped due to accessing HBase admin 
> upon every FlowFile transfer
> -------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4866
>                 URL: https://issues.apache.org/jira/browse/NIFI-4866
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>            Priority: Critical
>             Fix For: 1.6.0
>
>
> NIFI-4543 added 
> "connection.getAdmin().getClusterStatus().getMaster().getHostAndPort()” call 
> from HBase_1_1_2_ClientService.toTransitUri method in order to get HBase 
> master address, which is called upon every FlowFile transfer and essentially 
> doubles the traffic through the HBase connector.
> The performance of our PutHBaseJSON processor dropped to 1/3 after deploying 
> NiFi 1.5.0.
> Those lines of code should be moved from toTransitUri to createConnection.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to