Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2294#discussion_r167858912
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.hbase;
+
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+
+@WritesAttributes(
+ value = {
+ @WritesAttribute( attribute = "restart.index", description = "If a
delete batch fails, 'restart.index' attribute is added to the FlowFile and sent
to 'failure' " +
+ "relationship, so that this processor can retry from there
when the same FlowFile is routed again." ),
+ @WritesAttribute( attribute = "rowkey.start", description = "The
first rowkey in the flowfile. Only written when a flowfile contains multiple
deletes."),
+ @WritesAttribute( attribute = "rowkey.end", description = "The
last rowkey in the flowfile. Only written when a flowfile contains multiple
deletes.")
+ }
+)
+@Tags({ "delete", "hbase" })
+@CapabilityDescription(
+ "Delete HBase records individually or in batches. The input can be
a single row ID in the body, one ID per line, " +
+ "row IDs separated by commas or a combination of the two. ")
+public class DeleteHBaseRow extends AbstractDeleteHBase {
+ static final AllowableValue ROW_ID_BODY = new AllowableValue("body",
"FlowFile content", "Get the row key(s) from the flowfile content.");
--- End diff --
I'd suggest keep the naming consistent. Both of `body` and `content` are
used, but it would be cleaner if we use just one of them. If so, I'd prefer
`content`.
---
