Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2467
  
    Thanks for your first contribution to Apache NiFi. I have made some inline 
comments on the code. Please also add a unit test covering the new 
functionality you added. You can see existing unit tests for this code in 
[`TestSelectHiveQL`](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/processors/hive/TestSelectHiveQL.java#L63).
 Our [Contributor 
Guide](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide) also 
has helpful information to make your submission review go as smoothly as 
possible. 


---

Reply via email to