[ 
https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362849#comment-16362849
 ] 

ASF GitHub Bot commented on NIFI-4862:
--------------------------------------

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2467
  
    Thanks for your first contribution to Apache NiFi. I have made some inline 
comments on the code. Please also add a unit test covering the new 
functionality you added. You can see existing unit tests for this code in 
[`TestSelectHiveQL`](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/processors/hive/TestSelectHiveQL.java#L63).
 Our [Contributor 
Guide](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide) also 
has helpful information to make your submission review go as smoothly as 
possible. 


> Add Copy original attributtes to SelectHiveQL processer
> -------------------------------------------------------
>
>                 Key: NIFI-4862
>                 URL: https://issues.apache.org/jira/browse/NIFI-4862
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.5.0
>            Reporter: Jakub Leś
>            Priority: Minor
>         Attachments: 
> 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch
>
>
> Hi, 
> Please add "Copy original attributes" to processor SelectHiveQL. Thanks to 
> that we can use HttpRequest and HttpResponse to synchronize fetching query 
> result in webservice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to