[
https://issues.apache.org/jira/browse/NIFI-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364433#comment-16364433
]
ASF GitHub Bot commented on NIFI-4864:
--------------------------------------
GitHub user zenfenan opened a pull request:
https://github.com/apache/nifi/pull/2470
NIFI-4864 Fixing additional resources property pointing to directory won't
find new resources
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zenfenan/nifi NIFI-4864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2470.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2470
----
commit d1290d03e68cac77e6e1f332368bbadc8ced9043
Author: zenfenaan <sivaprasanna246@...>
Date: 2018-01-12T17:15:13Z
NIFI-4770 ListAzureBlobStorage now properly writes azure.container flowfile
attribute
commit 615f3ebc10d94f37c7463ae2d240582397e6ce8c
Author: zenfenan <sivaprasanna246@...>
Date: 2018-01-23T16:30:38Z
Merge branch 'master' of https://github.com/apache/nifi
commit f597a9b7aa11a48ff46931b73da216c8426542e4
Author: zenfenan <sivaprasanna246@...>
Date: 2018-01-26T04:42:32Z
Merge remote-tracking branch 'nifi/master'
commit b546f22cfe103eca83f2e32b71d0011927a7f0ce
Author: zenfenan <sivaprasanna246@...>
Date: 2018-01-29T09:53:35Z
Merge remote-tracking branch 'nifi/master'
commit d0b14da7ab85006a9f8ea1c936e2fdfe18966f7e
Author: zenfenan <sivaprasanna246@...>
Date: 2018-02-12T15:09:48Z
Merge remote-tracking branch 'nifi/master'
commit f3ced742604924964926e5ee2c4ce271fb5bb9bf
Author: zenfenan <sivaprasanna246@...>
Date: 2018-02-14T16:09:04Z
NIFI-4864 Fixing Additional Resources property pointing at a directory
won't find new JARs
----
> Additional Resources property pointing at a directory won't find new JARs
> -------------------------------------------------------------------------
>
> Key: NIFI-4864
> URL: https://issues.apache.org/jira/browse/NIFI-4864
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.5.0
> Reporter: Bryan Bende
> Assignee: zenfenan
> Priority: Minor
>
> If you have a processor/Controller Service/Reporting Task that has a property
> with dynamicallyModifiesClasspath(true) and you set the value to a directory,
> the resources in that directory will only be calculated when that property
> changes. This means if you added JARs to the directory later, and stopped and
> started your processor, those new JARs still won't be available. You would
> have to change the property to a new directory, or back and forth to some
> other directory, to force a recalculation.
> The setProperties method in AbstractConfiguredComponent is where it looks at
> incoming property changes and determines if any were for classpath related
> properties and then calls reload accordingly.
> We would need to consider the case where setProperties is never even being
> called, someone just stops and starts the processor and would want to pick up
> any new JARs added.
> A possible solution might be to computer some kind of hash/fingerprint of the
> URLs each time reload is called, and then when starting the processor we
> could recompute the fingerprint and compare it to the previous one. If they
> are different then we call reload before starting the component.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
