[
https://issues.apache.org/jira/browse/NIFI-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368768#comment-16368768
]
ASF GitHub Bot commented on NIFI-4859:
--------------------------------------
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi/pull/2479
NIFI-4859 NIFI-4835 Swagger spec fixes
This PR contains two commits:
- NIFI-4859 Corrects Swagger Spec VersionedFlowState allowableValues
- NIFI-4835 Corrects Swagger spec response types in FlowResource
There is no functionality change, just REST API documentation fixes.
---
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi NIFI-4859
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2479
----
commit e2c470dc6f674131c9ab9d8b010214e1487a4262
Author: Kevin Doran <kdoran@...>
Date: 2018-02-19T03:12:27Z
NIFI-4859 Corrects Swagger Spec VersionedFlowState allowableValues
commit ef86bd02a1694d0685dfb276e019d6954b448ddd
Author: Kevin Doran <kdoran@...>
Date: 2018-02-19T03:15:01Z
NIFI-4835 Corrects Swagger spec response types in FlowResource
----
> Swagger Spec VersionControlInformationDTO missing SYNC_FAILURE state
> --------------------------------------------------------------------
>
> Key: NIFI-4859
> URL: https://issues.apache.org/jira/browse/NIFI-4859
> Project: Apache NiFi
> Issue Type: Bug
> Components: Flow Versioning
> Affects Versions: 1.5.0
> Reporter: Daniel Chaffelson
> Assignee: Kevin Doran
> Priority: Minor
> Labels: swagger
> Fix For: 1.6.0
>
>
> It is possible to get a Versioned Process Group into a SYNC_FAILURE state,
> but this is not an allowable state in the code generated from the swagger.json
> This prevents versioned objects from being manipulated via the API in some
> use cases.
> {noformat}
> @state.setter
> def state(self, state):
> """
> Sets the state of this VersionControlInformationDTO.
> The current state of the Process Group, as it relates to the Versioned Flow
> :param state: The state of this VersionControlInformationDTO.
> :type: str
> """
> allowed_values = ["LOCALLY_MODIFIED_DESCENDANT", "LOCALLY_MODIFIED", "STALE",
> "LOCALLY_MODIFIED_AND_STALE", "UP_TO_DATE"]
> if state not in allowed_values:
> raise ValueError(
> "Invalid value for `state` ({0}), must be one of {1}"
> > .format(state, allowed_values)
> )
> E ValueError: Invalid value for `state` (SYNC_FAILURE), must be one of
> ['LOCALLY_MODIFIED_DESCENDANT', 'LOCALLY_MODIFIED', 'STALE',
> 'LOCALLY_MODIFIED_AND_STALE', 'UP_TO_DATE']
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
