ASF GitHub Bot commented on MINIFICPP-406:

GitHub user phrocker opened a pull request:


    MINIFICPP-406: Ensure that Context Service OR minifi properties can b…

    …e used
    to configure secure comms ( HTTP & Socket)
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    - [ ] Is your initial contribution a single, squashed commit?
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-406

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
commit 323cc41564608d73a66ff1edeeacca4ee310b2dd
Author: Marc Parisi <phrocker@...>
Date:   2018-02-17T18:00:26Z

    MINIFICPP-406: Ensure that Context Service OR minifi properties can be used
    to configure secure comms ( HTTP & Socket)


> Change StreamFactory to use SSLContextService if one is available. 
> -------------------------------------------------------------------
>                 Key: MINIFICPP-406
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-406
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Major
> Currently socket coordination is done through minifi.properties and is 
> unaware of any context service. We should change this to make configuration 
> consistent. 

This message was sent by Atlassian JIRA

Reply via email to