[
https://issues.apache.org/jira/browse/NIFI-4902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371488#comment-16371488
]
ASF GitHub Bot commented on NIFI-4902:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2485
NIFI-4902: Updated ConsumeAMQP, PublishAMQP to use one connection per…
… concurrent task instead of a single connection shared by all concurrent
tasks. This offers far better throughput when the network latency is
non-trivial. Also refactored to simplify code
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4902
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2485.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2485
----
commit b9e801e889b32cde415920eda1c5cef2af5fd41e
Author: Mark Payne <markap14@...>
Date: 2018-02-21T14:31:36Z
NIFI-4902: Updated ConsumeAMQP, PublishAMQP to use one connection per
concurrent task instead of a single connection shared by all concurrent tasks.
This offers far better throughput when the network latency is non-trivial. Also
refactored to simplify code
----
> ConsumeAMQP and PublishAMQP use a single connection, which results in poor
> performance
> --------------------------------------------------------------------------------------
>
> Key: NIFI-4902
> URL: https://issues.apache.org/jira/browse/NIFI-4902
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.6.0
>
>
> PublishAMQP and ConsumeAMQP both use a single underlying connection,
> regardless of how many concurrent tasks are available. As a result, this
> leads to poor performance when the network latency is not extremely small.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)