[
https://issues.apache.org/jira/browse/NIFI-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371489#comment-16371489
]
ASF GitHub Bot commented on NIFI-4901:
--------------------------------------
GitHub user gardellajuanpablo opened a pull request:
https://github.com/apache/nifi/pull/2486
NIFI-4901 Json to Avro using Record framework does not support union …
…types with boolean
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gardellajuanpablo/nifi OptionalBoolean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2486.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2486
----
commit 286b9ac3012c6b9118f947663b7458b493658d87
Author: gardellajuanpablo <gardellajuanpablo@...>
Date: 2018-02-21T14:36:00Z
NIFI-4901 Json to Avro using Record framework does not support union types
with boolean
----
> Json to Avro using Record framework does not support union types with boolean
> -----------------------------------------------------------------------------
>
> Key: NIFI-4901
> URL: https://issues.apache.org/jira/browse/NIFI-4901
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.5.0
> Environment: ALL
> Reporter: Gardella Juan Pablo
> Priority: Major
> Attachments: optiona-boolean.zip
>
>
> Given the following valid Avro Schema:
> {code}
> {
> "type":"record",
> "name":"foo",
> "fields":[
> {
> "name":"isSwap",
> "type":[
> "boolean",
> "null"
> ]
> }
> ]
> }
> {code}
> And the following JSON:
> {code}
> {
> "isSwap": {
> "boolean": true
> }
> }
> {code}
> When it is trying to be converted to Avro using ConvertRecord fails with:
> {{org.apache.nifi.serialization.MalformedRecordException: Successfully parsed
> a JSON object from input but failed to convert into a Record object with the
> given schema}}
> Attached a repository to reproduce the issue and also included the fix:
> * Run {{mvn clean test}} to reproduce the issue.
> * Run {{mvn clean test -Ppatch}} to test the fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
