[
https://issues.apache.org/jira/browse/NIFI-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373160#comment-16373160
]
ASF GitHub Bot commented on NIFI-4774:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2487
NIFI-4774: Allow user to choose which write-ahead log implementation …
…should be used by the WriteAheadFlowFileRepository
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4774-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2487.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2487
----
commit 07c1b1140178b83d69f31a4ec99e8a23d134d962
Author: Mark Payne <markap14@...>
Date: 2018-02-22T17:51:38Z
NIFI-4774: Allow user to choose which write-ahead log implementation should
be used by the WriteAheadFlowFileRepository
----
> FlowFile Repository should write updates to the same FlowFile to the same
> partition
> -----------------------------------------------------------------------------------
>
> Key: NIFI-4774
> URL: https://issues.apache.org/jira/browse/NIFI-4774
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.6.0
>
>
> As-is, in the case of power loss or Operating System crash, we could have an
> update that is lost, and then an update for the same FlowFile that is not
> lost, because the updates for a given FlowFile can span partitions. If an
> update were written to Partition 1 and then to Partition 2 and Partition 2 is
> flushed to disk by the Operating System and then the Operating System crashes
> or power is lost before Partition 1 is flushed to disk, we could lose the
> update to Partition 1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
