[
https://issues.apache.org/jira/browse/NIFI-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373321#comment-16373321
]
ASF GitHub Bot commented on NIFI-4827:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2443#discussion_r170070317
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
---
@@ -226,6 +242,8 @@ private ObjectWriter getObjectWriter(ObjectMapper
mapper, String ppSetting) {
@Override
public void onTrigger(final ProcessContext context, final
ProcessSession session) throws ProcessException {
+ FlowFile input = session.get();
--- End diff --
It's not checking for input == null here, that would be one of the
requirements for the "flowfile-driven behavior" rather than the "timer-driven
behavior". It might cause an NPE at line 266, and otherwise if null you may be
treating it as flowfile-driven when really it is more like timer-driven.
ExecuteSQL has a good example of how to handle this.
> Make GetMongo able to use flowfiles for queries
> -----------------------------------------------
>
> Key: NIFI-4827
> URL: https://issues.apache.org/jira/browse/NIFI-4827
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Mike Thomsen
> Assignee: Mike Thomsen
> Priority: Minor
>
> GetMongo should be able to retrieve a valid query from the flowfile content
> or allow the incoming flowfile to provide attributes to power EL statements
> in the Query configuration field. Allowing the body to be used would allow
> GetMongo to be used in a much more generic way.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
