Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2430#discussion_r170728915
  
    --- Diff: 
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/SiteToSiteMetricsReportingTask.java
 ---
    @@ -0,0 +1,151 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.reporting;
    +
    +import java.lang.management.ManagementFactory;
    +import java.lang.management.OperatingSystemMXBean;
    +import java.nio.charset.StandardCharsets;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.UUID;
    +import java.util.concurrent.TimeUnit;
    +
    +import javax.json.Json;
    +import javax.json.JsonBuilderFactory;
    +import javax.json.JsonObject;
    +
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.controller.status.ProcessGroupStatus;
    +import org.apache.nifi.processor.exception.ProcessException;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.remote.Transaction;
    +import org.apache.nifi.remote.TransferDirection;
    +import org.apache.nifi.reporting.util.metrics.MetricsService;
    +import org.apache.nifi.reporting.util.metrics.api.MetricsBuilder;
    +
    +import com.yammer.metrics.core.VirtualMachineMetrics;
    +
    +@Tags({"status", "metrics", "site", "site to site"})
    +@CapabilityDescription("Publishes same metrics as the Ambari Reporting 
task using the Site To Site protocol. "
    +        + "Metrics are formatted according to the Ambari Metrics API.")
    +public class SiteToSiteMetricsReportingTask extends 
AbstractSiteToSiteReportingTask {
    +
    +    static final String TIMESTAMP_FORMAT = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'";
    +
    +    static final PropertyDescriptor APPLICATION_ID = new 
PropertyDescriptor.Builder()
    +            .name("Application ID")
    --- End diff --
    
    Please set this(and the other properties) to a machine-friendly name, you 
can use the current value for .displayName()


---

Reply via email to