Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2475#discussion_r171064496
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitContent.java
 ---
    @@ -75,6 +77,7 @@
         @WritesAttribute(attribute = "fragment.count", description = "The 
number of split FlowFiles generated from the parent FlowFile"),
         @WritesAttribute(attribute = "segment.original.filename ", description 
= "The filename of the parent FlowFile")})
     @SeeAlso(MergeContent.class)
    +@SystemResourceConsideration(resource = SystemResource.MEMORY)
    --- End diff --
    
    I would again add a description here that indicates that it's not buffering 
the content in memory but rather just storing the FlowFile w/ its attributes in 
memory and that if generating too many splits, a two-phase approach may be 
necessary.


---

Reply via email to