[
https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380699#comment-16380699
]
ASF GitHub Bot commented on NIFI-4916:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2500
NIFI-4916 - ConvertExcelToCSVProcessor inherit parent attributes
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-4916
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2500.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2500
----
commit b58180cf96ad93a0e5b6584f9fd1bf2ce40fbd07
Author: Pierre Villard <pierre.villard.fr@...>
Date: 2018-02-28T17:22:14Z
NIFI-4916 - ConvertExcelToCSVProcessor inherit parent attributes
----
> Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes
> -------------------------------------------------------------------------
>
> Key: NIFI-4916
> URL: https://issues.apache.org/jira/browse/NIFI-4916
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.5.0
> Environment: NiFi 1.5.0
> Reporter: Fabio Coutinho
> Priority: Major
> Attachments: ProvenanceCsvFlowFile.png, ProvenanceXlsFlowFile.png
>
>
> When converting a flowfile containing an XLS file to CSV, the newly generated
> flowfiles do not inherit the attributes from the original one.
> Without the original flowfile's attributes, important information retrieved
> before conversion (for example, file metadata) cannot be used after the file
> is converted. I have attached 2 image files showing the attributes before and
> after conversion. Please note that the input file has a lot of metadata
> retrieved from Amazon S3 that does not exist on the new flowfile.
> I believe that like most other NiFi processors, the original attributes
> should be copied to new flowfiles.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
