[
https://issues.apache.org/jira/browse/NIFI-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383712#comment-16383712
]
ASF GitHub Bot commented on NIFI-4773:
--------------------------------------
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2504#discussion_r171882320
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
---
@@ -197,6 +198,12 @@ public void setup(final ProcessContext context) {
maxValueProperties =
getDefaultMaxValueProperties(context.getProperties());
}
+ @OnStopped
+ public void stop() {
+ // Reset the column type map in case properties change
+ setupComplete.set(false);
--- End diff --
can't we just do the setup in `@OnScheduled` and move the setupComplete
flag only to `GenerateTableFetch` or remove it? I think the code would be more
straightforward like this. What do you think?
> Database Fetch processor setup is incorrect
> -------------------------------------------
>
> Key: NIFI-4773
> URL: https://issues.apache.org/jira/browse/NIFI-4773
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Wynner
> Assignee: Matt Burgess
> Priority: Major
> Fix For: 1.6.0
>
>
> The QueryDatabaseTable processor attempts to make a database connection
> during setup (OnScheduled), this can cause issues with the flow when errors
> occur.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
