[ 
https://issues.apache.org/jira/browse/NIFI-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383728#comment-16383728
 ] 

ASF GitHub Bot commented on NIFI-4920:
--------------------------------------

GitHub user bbende opened a pull request:

    https://github.com/apache/nifi/pull/2505

    NIFI-4920 Skipping sensitive properties when updating component prope…

    …rties from versioned component
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bbende/nifi NIFI-4920

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2505
    
----
commit 0b23d961ae3ff089f469a1e8768c854d10777ce8
Author: Bryan Bende <bbende@...>
Date:   2018-03-02T15:52:22Z

    NIFI-4920 Skipping sensitive properties when updating component properties 
from versioned component

----


> Change Version & Revert Local Changes incorrectly reset sensitive properties
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-4920
>                 URL: https://issues.apache.org/jira/browse/NIFI-4920
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Bryan Bende
>            Priority: Major
>
> Create a flow with a processor that has a sensitive property and set a value, 
> save v1 of the flow to registry.
> Make some local changes to the flow and then revert local changes and notice 
> the sensitive property is no longer set.
> Set the sensitive property again, make some other change to the flow, and 
> save v2.
> Change version back to v1 and notice the sensitive property is no longer set 
> again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to