Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2504#discussion_r171886997
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
 ---
    @@ -197,6 +198,12 @@ public void setup(final ProcessContext context) {
             maxValueProperties = 
getDefaultMaxValueProperties(context.getProperties());
         }
     
    +    @OnStopped
    +    public void stop() {
    +        // Reset the column type map in case properties change
    +        setupComplete.set(false);
    --- End diff --
    
    That's what it used to do, NIFI-4773 was to do the opposite. It's not 
recommended to try to connect to external systems in `@OnScheduled` due to 
timeouts and other possible errors. Instead we moved it into onTrigger but only 
to be done once.


---

Reply via email to