[ 
https://issues.apache.org/jira/browse/NIFI-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386179#comment-16386179
 ] 

ASF GitHub Bot commented on NIFI-4838:
--------------------------------------

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2448#discussion_r172216534
  
    --- Diff: 
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
 ---
    @@ -121,34 +136,53 @@
                 .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
                 .build();
     
    -    static final PropertyDescriptor BATCH_SIZE = new 
PropertyDescriptor.Builder()
    -            .name("Batch Size")
    -            .description("The number of elements returned from the server 
in one batch")
    +    static final PropertyDescriptor FETCH_SIZE = new 
PropertyDescriptor.Builder()
    +            .name("Fetch Size")
    --- End diff --
    
    I missed that it was `name` and not `displayName`.
    
    Maybe what should be done here is to revert that change, and then have the 
commits happen either after reach flowfile (when grouped into big flowfiles) or 
after each batch as defined in that property for the 1:1 result/flowfile option.


> Make GetMongo support multiple commits and give some progress indication
> ------------------------------------------------------------------------
>
>                 Key: NIFI-4838
>                 URL: https://issues.apache.org/jira/browse/NIFI-4838
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Major
>
> It shouldn't wait until the end to do a commit() call because the effect is 
> that GetMongo looks like it has hung to a user who is pulling a very large 
> data set.
> It should also have an option for running a count query to get the current 
> approximate count of documents that would match the query and append an 
> attribute that indicates where a flowfile stands in the total result count. 
> Ex:
> query.progress.point.start = 2500
> query.progress.point.end = 5000
> query.count.estimate = 17,568,231



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to