[
https://issues.apache.org/jira/browse/NIFI-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387798#comment-16387798
]
ASF GitHub Bot commented on NIFI-4938:
--------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2514#discussion_r172519579
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java
---
@@ -17,16 +17,7 @@
package org.apache.nifi.processors.mqtt.common;
-import org.eclipse.paho.client.mqttv3.IMqttClient;
-import org.eclipse.paho.client.mqttv3.IMqttDeliveryToken;
-import org.eclipse.paho.client.mqttv3.IMqttToken;
-import org.eclipse.paho.client.mqttv3.MqttCallback;
-import org.eclipse.paho.client.mqttv3.MqttConnectOptions;
-import org.eclipse.paho.client.mqttv3.MqttException;
-import org.eclipse.paho.client.mqttv3.MqttMessage;
-import org.eclipse.paho.client.mqttv3.MqttPersistenceException;
-import org.eclipse.paho.client.mqttv3.MqttSecurityException;
-import org.eclipse.paho.client.mqttv3.MqttTopic;
+import org.eclipse.paho.client.mqttv3.*;
--- End diff --
please avoid star import. Be sure to run
mvn clean install -Pcontrib-check
> Offline buffering is not supported by paho client version 1.0.2 used in mqtt
> processors.
> ----------------------------------------------------------------------------------------
>
> Key: NIFI-4938
> URL: https://issues.apache.org/jira/browse/NIFI-4938
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Himanshu Mishra
> Priority: Major
>
> Off line buffering is not supported by paho client version 1.0.2 used in mqtt
> processors which causes problem of "message loss" with QoS 1 and QoS 2 for
> mqtt messages when the client connectivity is lost.
> The version 1.2.0 of paho client supports this off line buffering. Thus
> addressing this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
