[ 
https://issues.apache.org/jira/browse/NIFI-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390186#comment-16390186
 ] 

ASF GitHub Bot commented on NIFI-4637:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2518#discussion_r172972637
  
    --- Diff: 
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseCell.java
 ---
    @@ -96,16 +97,18 @@ protected PutFlowFile createPut(final ProcessSession 
session, final ProcessConte
     
     
             final byte[] buffer = new byte[(int) flowFile.getSize()];
    -        session.read(flowFile, new InputStreamCallback() {
    -            @Override
    -            public void process(final InputStream in) throws IOException {
    -                StreamUtils.fillBuffer(in, buffer);
    -            }
    -        });
    +        session.read(flowFile, in -> StreamUtils.fillBuffer(in, buffer));
     
    +        PutColumn column = null;
    +        if (visibilityStringToUse != null && 
!visibilityStringToUse.equals("")) {
    --- End diff --
    
    Cosmetic comment - feel free to ignore.
    ````java
    PutColumn column = StringUtils.isEmpty(visibilityStringToUse)
        ? new PutColumn(columnFamily.getBytes(StandardCharsets.UTF_8),
                        columnQualifier.getBytes(StandardCharsets.UTF_8), 
buffer, timestamp)
        : new PutColumn(columnFamily.getBytes(StandardCharsets.UTF_8),
                        columnQualifier.getBytes(StandardCharsets.UTF_8), 
buffer, timestamp, visibilityStringToUse);
    ````


> Add support for HBase visibility labels to HBase processors and controller 
> services
> -----------------------------------------------------------------------------------
>
>                 Key: NIFI-4637
>                 URL: https://issues.apache.org/jira/browse/NIFI-4637
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Major
>
> HBase supports visibility labels, but you can't use them from NiFi because 
> there is no way to set them. The existing processors and services should be 
> upgraded to handle this capability.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to