[
https://issues.apache.org/jira/browse/NIFI-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396973#comment-16396973
]
ASF GitHub Bot commented on NIFI-4849:
--------------------------------------
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r174139485
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/StatusMerger.java
---
@@ -626,6 +634,132 @@ public static void merge(final
SystemDiagnosticsSnapshotDTO target, final System
updatePrettyPrintedFields(target);
}
+ public static void merge(final JVMDiagnosticsSnapshotDTO target, final
JVMDiagnosticsSnapshotDTO toMerge, final long numMillis) {
+ if (target == null || toMerge == null) {
+ return;
+ }
+
+ if (toMerge.getControllerDiagnostics() == null) {
+ target.setControllerDiagnostics(null);
+ } else {
+ merge(target.getControllerDiagnostics(),
toMerge.getControllerDiagnostics());
+ }
+
+ if (toMerge.getFlowDiagnosticsDto() == null) {
+ target.setFlowDiagnosticsDto(null);
+ } else {
+ merge(target.getFlowDiagnosticsDto(),
toMerge.getFlowDiagnosticsDto());
+ }
+
+ if (toMerge.getSystemDiagnosticsDto() == null) {
+ target.setSystemDiagnosticsDto(null);
+ } else {
+ merge(target.getSystemDiagnosticsDto(),
toMerge.getSystemDiagnosticsDto(), numMillis);
+ }
+ }
+
+ private static void merge(final JVMControllerDiagnosticsSnapshotDTO
target, final JVMControllerDiagnosticsSnapshotDTO toMerge) {
+ if (toMerge == null || target == null) {
+ return;
+ }
+
+
target.setMaxEventDrivenThreads(add(target.getMaxEventDrivenThreads(),
toMerge.getMaxEventDrivenThreads()));
+
target.setMaxTimerDrivenThreads(add(target.getMaxTimerDrivenThreads(),
toMerge.getMaxTimerDrivenThreads()));
--- End diff --
Do we want to add these maxThread fields?
> Add REST Endpoint for gathering Processor Diagnostics information
> -----------------------------------------------------------------
>
> Key: NIFI-4849
> URL: https://issues.apache.org/jira/browse/NIFI-4849
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.6.0
>
>
> We need to add a REST endpoint that will use the appropriate resources to
> gather the Processor Diagnostics information. Information to return should
> include things like:
> * Processor config
> * Processor status
> * Garbage Collection info
> * Repo Sizes
> * Connection info for connections whose source or destination is the
> processor
> * Controller Services that the processor is referencing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
