Github user robertrbruno commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2501#discussion_r174307349
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/NullSuppression.java
 ---
    @@ -0,0 +1,24 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.processors.elasticsearch;
    +
    +public enum NullSuppression {
    +    ALWAYS_SUPPRESS,
    +    NEVER_SUPPRESS,
    +    SUPPRESS_MISSING
    --- End diff --
    
    Agreed that allowable values could be used where enum is used.   Enum was 
only used to be consistent with how JsonRecordSetWriter was written.  I feel it 
would be simpler without the enum though.


---

Reply via email to