Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2085
There are merge conflicts in `InvokeHTTP` and in a number of the poms. I
believe I have resolved all of these
[6a80063313f9c8e03a1f42ae84813cabd5fc8349](https://github.com/alopresto/nifi/commit/6a80063313f9c8e03a1f42ae84813cabd5fc8349).
There are also the following issues:
* It looks like somehow an empty file was added at
`nifi/nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/webapp/WEB-INF/jsp/authorize.jsp`.
I only noticed this because it failed the RAT check. I imagine this can be
deleted?
* An unused field remains in `AbstractOAuthControllerService`: `protected
long expireTimeSafetyNetSeconds = -1;`
* `OAuth2ClientCredentialsGrantControllerService.CLIENT_ID` and
`OAuth2ClientCredentialsGrantControllerService.CLIENT_SECRET` don't support
expression language (with the variable registry and NiFi Registry, these values
will likely be populated externally)
* The exception handling in
`OAuth2ClientCredentialsGrantControllerService#authenticate` can be condensed
* There are no unit or integration tests. I understand a real integration
test with an external service is difficult, but unit tests for
`OAuth2ClientCredentialsGrantControllerService#authenticate()` (via mocking
`OAuthHTTPConnectionClient#execute()`) and
`AbstractOAuthControllerService#isOAuthTokenExpired()` would be helpful
* There is no update to the User Guide or Admin Guide describing this
feature. At a minimum, the `InvokeHTTP` processor documentation should be
updated
I am in the process of configuring an external OAuth service to use with
this. Will have a final review once that evaluation is complete.
---
