[
https://issues.apache.org/jira/browse/NIFI-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399678#comment-16399678
]
ASF GitHub Bot commented on NIFI-4977:
--------------------------------------
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/2547
NIFI-4977 Adding expression language support to the Sender properties…
… of PutSyslog
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi
NIFI-4977_Exposing_EL_in_PutSyslog
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2547.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2547
----
commit e9b731529a243ec439760a758cb0c809f7f8cd93
Author: Joe Percivall <jpercivall@...>
Date: 2018-03-15T00:39:04Z
NIFI-4977 Adding expression language support to the Sender properties of
PutSyslog
----
> PutSyslog should support Expression Language for it's Sender properties
> -----------------------------------------------------------------------
>
> Key: NIFI-4977
> URL: https://issues.apache.org/jira/browse/NIFI-4977
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Priority: Minor
>
> As part of the continued effort to add access to the variable registry to
> processors, the PutSyslog processor should expose expression language to it's
> sender properties. These properties control where and how the processor sends
> to.
> This update should better align PutSyslog with the other PutX processors
> which support EL on the sender properties (Slack, TCP, UDP).
> These properties are not evaluated per FlowFile and shouldn't be expected to
> change between onTriggers (since the sender pool is shared) so it will need
> to be documented as such that the
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
