Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2523#discussion_r174820659
--- Diff:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/StandardSchemaIdentifier.java
---
@@ -64,6 +75,49 @@ public boolean equals(final Object obj) {
return false;
}
final SchemaIdentifier other = (SchemaIdentifier) obj;
- return getName().equals(other.getName()) &&
getIdentifier().equals(other.getIdentifier()) &&
getVersion().equals(other.getVersion());
+ return getName().equals(other.getName())
+ && getIdentifier().equals(other.getIdentifier())
+ && getVersion().equals(other.getVersion())
+ && getBranch().equals(other.getBranch());
+ }
+
+ /**
+ * Builder to create instances of Schema
--- End diff --
Think that's a typo - should be "Builder to create instances of Schema
Identifier" - it doesn't build a Schema, just the identifier.
---
