[
https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400961#comment-16400961
]
ASF GitHub Bot commented on NIFI-4935:
--------------------------------------
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2523#discussion_r174895242
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access/HortonworksAttributeSchemaReferenceStrategy.java
---
@@ -84,7 +85,8 @@ public RecordSchema getSchema(Map<String, String>
variables, final InputStream c
final long schemaId = Long.parseLong(schemaIdentifier);
final int version = Integer.parseInt(schemaVersion);
--- End diff --
I think I decided to leave the attribute strategy alone to avoid creating
extra complexity..
Currently the attributes approach provides a direct lookup by id+version
(which would disambiguate the branch) and users are accustomed to using this
strategy when they want a specific version.
If we then allow the option to use branch instead of version, the combo of
id+branch would then get the latest version on the given branch, instead of a
direct look up.
Also, since we now allow specifying a version with access-by-name strategy,
I wonder how often the attributes approach would even be used.
If you feel strongly about it we can definitely make it work though.
> Support Schema Branches when using HWX Schema Registry
> ------------------------------------------------------
>
> Key: NIFI-4935
> URL: https://issues.apache.org/jira/browse/NIFI-4935
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
>
> The latest version of Hortonworks Schema Registry now supports a
> forking/branching concept. This means that when retrieving a schema by name,
> it may be desirable to also specify a branch name, as the default would
> retrieve from the "master" branch. We'll need to pass down an optional branch
> name to the SchemaRegistry implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
