Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2473#discussion_r175000487
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/csv/TestCSVRecordReader.java
 ---
    @@ -106,6 +117,195 @@ public void testDate() throws IOException, 
MalformedRecordException {
             }
         }
     
    +    @Test
    +    public void testDateNoCoersionSuccess() throws IOException, 
MalformedRecordException {
    --- End diff --
    
    The purpose of test would be clearer if we name this as 
'testDateNoCoersionExpectedFormat'.
    Same comment goes for time and timestamp tests, too.


---

Reply via email to