[ 
https://issues.apache.org/jira/browse/MINIFICPP-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402158#comment-16402158
 ] 

ASF GitHub Bot commented on MINIFICPP-404:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/280#discussion_r175146488
  
    --- Diff: extensions/http-curl/client/HTTPClient.h ---
    @@ -172,6 +172,20 @@ class HTTPClient : public BaseHTTPClient, public 
core::Connectable {
     
       void setPostSize(size_t size);
     
    +  void setHTTPProxy(const utils::HTTPProxy &proxy) override {
    +    if (!proxy.host.empty()) {
    +      curl_easy_setopt(http_session_, CURLOPT_PROXY, proxy.host.c_str());
    +      curl_easy_setopt(http_session_, CURLOPT_PROXYPORT, proxy.port);
    +      if (!proxy.username.empty()) {
    +        /* allow whatever auth the proxy speaks */
    --- End diff --
    
    Might help to change the comments since they're identical to 
https://curl.haxx.se/libcurl/c/CURLOPT_PROXYAUTH.html


> HTTP Proxy Support for HTTP Site to Site
> ----------------------------------------
>
>                 Key: MINIFICPP-404
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-404
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: bqiu
>            Assignee: bqiu
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> HTTP Proxy Support for HTTP Site to Site
> http://nifi.apache.org/docs/nifi-docs/html/user-guide.html#configure-site-to-site-client-nifi-instance.
>  support for this in YAML config via 
> https://github.com/apache/nifi-minifi/blob/master/minifi-docs/src/main/markdown/System_Admin_Guide.md#remote-process-groups-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to