Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2497#discussion_r175197796
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowFileQueue.java
 ---
    @@ -139,6 +137,36 @@ public StandardFlowFileQueue(final String identifier, 
final Connection connectio
     
             readLock = new TimedLock(this.lock.readLock(), identifier + " Read 
Lock", 100);
             writeLock = new TimedLock(this.lock.writeLock(), identifier + " 
Write Lock", 100);
    +
    +        NiFiProperties nifiProps = 
NiFiProperties.createBasicNiFiProperties(null, null);
    --- End diff --
    
    This current approach will load the properties file every time a connection 
is created. Can we follow the approach that was taken with the 
`queueSwapThreshold` instead? Usually, this sort of parsing logic is in 
`NiFiProperties` so that `getBackPressureObjectThreshold` and 
`getBackPressureDataSizeThreshold` return the parsed value. 


---

Reply via email to