Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/289#discussion_r176229379
  
    --- Diff: CMakeLists.txt ---
    @@ -25,8 +25,10 @@ set(PROJECT_VERSION_MINOR 4)
     set(PROJECT_VERSION_PATCH 0)
     option(SKIP_TESTS "Skips building all tests." OFF)
     option(PORTABLE "Instructs the compiler to remove architecture specific 
optimizations" ON)
    +option(USE_SYSTEM_OPENSSL "Instructs the build system to search for and 
use an SSL library available in the host system" OFF)
    --- End diff --
    
    I'm not in favor of changing the system dependency in a minor release. I 
would be in favor of moving to USE_SYSTEM_OPENSSL as the default until the next 
major release. 


---

Reply via email to