[
https://issues.apache.org/jira/browse/NIFI-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409617#comment-16409617
]
ASF GitHub Bot commented on NIFI-4857:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2570#discussion_r176437638
--- Diff:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
---
@@ -1100,4 +1189,16 @@ public static boolean isScalarValue(final DataType
dataType, final Object value)
return true;
}
+
+ public static Charset getCharset(String charsetName) {
+ if(charsetName == null) {
+ return StandardCharsets.UTF_8;
+ } else {
+ try {
+ return Charset.forName(charsetName);
+ } catch(Exception e) {
--- End diff --
If given an invalid character set, I think I would prefer to just throw the
Exception. If there is a typo somewhere, this can lead to some very unexpected
results that are difficult to track down.
> Record components do not support String <-> byte[] conversions
> --------------------------------------------------------------
>
> Key: NIFI-4857
> URL: https://issues.apache.org/jira/browse/NIFI-4857
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> When trying to perform a conversion of a field between a String and a byte
> array, various errors are reporting (depending on where the conversion is
> taking place). Here are some examples:
> 1) CSVReader, if a column with String values is specified in the schema as
> "bytes"
> 2) ConvertRecord, if an input field is of type String and the output field is
> of type "bytes"
> 3) ConvertRecord, if an input field is of type "bytes" and the output field
> is of type "String"
> Many/most/all of the record components use utility methods to convert values,
> I believe these methods need to be updated to support conversion between
> String and byte[] values.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
