Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2562#discussion_r176529115
  
    --- Diff: 
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITExecuteInfluxDBQuery.java
 ---
    @@ -0,0 +1,163 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.influxdb;
    +import static org.junit.Assert.assertEquals;
    +import java.util.List;
    +import java.util.concurrent.TimeUnit;
    +
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.util.MockFlowFile;
    +import org.apache.nifi.util.TestRunners;
    +import org.influxdb.InfluxDB;
    +import org.influxdb.dto.QueryResult;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +/**
    + * Integration test for executing InfluxDB queries. Please ensure that the 
InfluxDB is running
    + * on local host with default port and has database test with table test. 
Please set user
    + * and password if applicable before running the integration tests.
    + */
    +public class ITExecuteInfluxDBQuery extends AbstractITInfluxDB {
    +
    +    @Before
    +    public void setUp() throws Exception {
    +        runner = TestRunners.newTestRunner(ExecuteInfluxDBQuery.class);
    +        initializeRunner();
    --- End diff --
    
    This can be merged into the other init function. It should at least come 
after the database init code so that you don't spend any time spinning up 
testing infra on the NiFi side if the database isn't working.


---

Reply via email to