[
https://issues.apache.org/jira/browse/NIFI-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410930#comment-16410930
]
ASF GitHub Bot commented on NIFI-4971:
--------------------------------------
GitHub user ijokarumawak reopened a pull request:
https://github.com/apache/nifi/pull/2542
NIFI-4971: ReportLineageToAtlas complete path can miss one-time lineages
The detailed explanation of this issue is written in the
[NIFI-4971](https://issues.apache.org/jira/browse/NIFI-4971) JIRA description
and comment. Please refer those as well.
- Separated Hook message de-duplication logic from NiFiAtlasHook to
NotificationSender
- NiFiAtlasHook used to send individual CREATE_ENTITY messages for each
entities,
this commit changed it to bundle all new entities into a single
CREATE_ENTITY to preserve entity creation order, so that new DataSet
entities can be referred from new nifi_flow_path entities
- Added more unit tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4971
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2542
----
commit 378e63fd78ed9bdf1fc8256e9d269ae6f17e4ade
Author: Koji Kawamura <ijokarumawak@...>
Date: 2018-03-09T00:27:20Z
NIFI-4971: ReportLineageToAtlas complete path can miss one-time lineages
- Separated Hook message de-duplication logic from NiFiAtlasHook to
NotificationSender
- NiFiAtlasHook used to send individual CREATE_ENTITY messages for each
entities,
this commit changed it to bundle all new entities into a single
CREATE_ENTITY to preserve entity creation order, so that new DataSet
entities can be referred from new nifi_flow_path entities
- Added more unit tests
----
> ReportLineageToAtlas 'complete path' strategy can miss one-time lineages
> ------------------------------------------------------------------------
>
> Key: NIFI-4971
> URL: https://issues.apache.org/jira/browse/NIFI-4971
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.5.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Priority: Major
>
> For the simplest example, with GetFlowFIle (GFF) -> PutFlowFile (PFF), where
> GFF gets files and PFF saves those files into a different directory, then
> following provenance events will be generated:
> # GFF RECEIVE file1
> # PFF SEND file2
> From above provenance events, following entities and lineages should be
> created in Atlas, labels in brackets are Atlas type names:
> {code}
> file1 (fs_path) -> GFF, PFF (nifi_flow_path) -> file2 (fs_path)
> {code}
> Entities shown in above graph are created. However, the 'nifi_flow_path'
> entity do not have inputs/outputs referencing 'fs_path', so lineage can not
> be seen in Atlas UI.
> This issue was discovered by [~nayakmahesh616]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
