[
https://issues.apache.org/jira/browse/NIFI-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411863#comment-16411863
]
ASF GitHub Bot commented on NIFI-5011:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2578
NIFI-5011: Fixed threading bug in TestFileSystemRepository
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5011
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2578
----
commit 71f8a7f8a085933d97c95ca4258f56e9bee3920b
Author: Mark Payne <markap14@...>
Date: 2018-03-23T18:33:53Z
NIFI-5011: Fixed threading bug in TestFileSystemRepository
----
> Test failure in TestFileSystemRepository causing travis build to be unstable
> ----------------------------------------------------------------------------
>
> Key: NIFI-5011
> URL: https://issues.apache.org/jira/browse/NIFI-5011
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Priority: Critical
> Fix For: 1.7.0
>
>
> We see the following test failure intermittently in travis:
> [ERROR] Tests run: 32, Failures: 0, Errors: 1, Skipped: 1, Time elapsed:
> 13.143 s <<< FAILURE! - in
> org.apache.nifi.controller.repository.TestFileSystemRepository [ERROR]
> testMinimalArchiveCleanupIntervalHonoredAndLogged(org.apache.nifi.controller.repository.TestFileSystemRepository)
> Time elapsed: 0.211 s <<< ERROR! java.util.ConcurrentModificationException
> at
> org.apache.nifi.controller.repository.TestFileSystemRepository.testMinimalArchiveCleanupIntervalHonoredAndLogged(TestFileSystemRepository.java:151)
>
> This appears to be a threading bug, giving that it's a
> ConcurrentModificationException that happens sporadically.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
