Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r177774022
--- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml ---
@@ -74,6 +75,22 @@
<artifactId>nifi-ssl-context-service-api</artifactId>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>com.google.code.gson</groupId>
+ <artifactId>gson</artifactId>
+ <version>2.7</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.solr</groupId>
+ <artifactId>solr-core</artifactId>
--- End diff --
Haven't made it through the rest of the PR yet, but what is the reason for
making solr-core a non-test dependency? It would be better if we could only
depend on Solr client.
If we do need to depend on solr-core we need to double check what
additional dependencies this brings into the Solr NAR and possibly update the
LICENSE/NOTICE of the NAR and the overall assembly. I would imagine solr-core
has a lot more dependencies than solr-client.
---
